-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: init #1
feat: init #1
Conversation
ocp_cluster_name=leogit delete_ocp_cluster=false
ocp_cluster_name=leogit delete_ocp_cluster=false
ocp_cluster_name=leogit2 delete_ocp_cluster=false
ocp_cluster_name=leogit delete_ocp_cluster=true
ocp_cluster_name=leogit3 delete_ocp_cluster=false
ocp_cluster_name=leogit2 delete_ocp_cluster=true
ocp_cluster_name=leogit4 delete_ocp_cluster=false
ocp_cluster_name=leogit4 delete_ocp_cluster=true
ocp_cluster_name=leogit3 delete_ocp_cluster=true
ocp_cluster_name=leogit4 delete_ocp_cluster=true
ocp_cluster_name=leogit5 delete_ocp_cluster=true
ocp_cluster_name=leogit5 delete_ocp_cluster=true
ocp_cluster_name=leogit6 delete_ocp_cluster=true
ocp_cluster_name=leogit5 delete_ocp_cluster=true
ocp_cluster_name=leogit7 delete_ocp_cluster=false
ocp_cluster_name=leogit7 delete_ocp_cluster=false
ocp_cluster_name=leogit7 delete_ocp_cluster=false
ocp_cluster_name=leogit7 delete_ocp_cluster=false
ocp_cluster_name=leogit8 delete_ocp_cluster=false
ocp_cluster_name=leogit7 delete_ocp_cluster=true
ocp_cluster_name=leogit8 delete_ocp_cluster=false
ocp_cluster_name=leogit8 delete_ocp_cluster=false
ocp_cluster_name=leogit9 delete_ocp_cluster=false
ocp_cluster_name=leogit8 delete_ocp_cluster=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't try it out but had a look at the github actions runs, which are using it successfully and looks really good so far!
Mostly just consistency / styling matters from my side.
Thanks for the review @Langleu! I made the requested adjustments, let me know if it works for you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small aws cli version adjustments.
And a small question for me to understand whether the multi apply would work.
Besides that, great work 🚀
This pull request addresses the implementation of the project outlined in https://github.com/camunda/team-infrastructure-experience/issues/237.
Since the project was recently created, I kindly ask for a comprehensive review of the entire project.
Details:
Thank you in advance for the time you will take to review this pull request :)